Skip to content

🐛 fix: fix hcard html tags #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

🐛 fix: fix hcard html tags #508

merged 1 commit into from
Apr 5, 2025

Conversation

mmai
Copy link
Contributor

@mmai mmai commented Apr 5, 2025

Summary

This fixes missing html closing tags in hcard template

Related issue

#507

Changes

In partials/hcard.html:

  • Add closing div tag
  • replace set by set_global in for loop

Type of change

  • [x ] Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@mmai mmai requested a review from welpo as a code owner April 5, 2025 20:22
Copy link

netlify bot commented Apr 5, 2025

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit a7c92bc
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/67f190f8effe6f0008e12495
😎 Deploy Preview https://deploy-preview-508--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants