-
-
Notifications
You must be signed in to change notification settings - Fork 65
✨ feat: add indicator to external links #443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
965911d
to
38c2243
Compare
welpo
added a commit
to welpo/osc.garden
that referenced
this pull request
Feb 15, 2025
welpo
added a commit
to welpo/osc.garden
that referenced
this pull request
Feb 15, 2025
This was referenced Feb 17, 2025
2 tasks
This was referenced Feb 18, 2025
This was referenced Mar 1, 2025
This was referenced Mar 10, 2025
This was referenced Mar 17, 2025
This was referenced Mar 24, 2025
This was referenced Mar 31, 2025
This was referenced Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds styling to links with
external
class. The class can be added to external links by the[markdown]
(not[extra]
) section inconfig.toml
:Related issue
This will be merged once getzola/zola#2717 makes it into the next version of Zola.
Changes
Adds reading-direction-agnostic CSS to style external links.
Accessibility
From my research, screen readers needn't mention a link is external; the visual indicator will be ignored.
Note: it's recommended to avoid setting links to open in new tabs (
external_links_target_blank
setting), as the W3C recommends:Screenshots
Type of change
Checklist
theme.toml
with a sane default for the featureconfig.toml
in tabi-startconfig.toml
commentstheme.toml
comments