Skip to content

fix: improve errors displayed on obs creation failure, do not fail clusterization #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025

Conversation

kristina-solovyova
Copy link
Contributor

@kristina-solovyova kristina-solovyova commented Mar 12, 2025

Tested on main.tf:

module "weka_deployment" {
  source                = "../.."
  prefix                = "ks"
  rg_name               = "kristina-test"
  cluster_name          = "kristina"
  allow_ssh_cidrs       = ["0.0.0.0/0"]
  allow_weka_api_cidrs = ["0.0.0.0/0"]
  cluster_size          = 6
  clients_number = 1
  weka_version = "4.4.4"
  subscription_id        = XXX
  get_weka_io_token = XXX
  assign_public_ip     = true

  tiering_enable_obs_integration = true
  tiering_obs_name = "kswekaobs"
  tiering_obs_container_name = "weka-obs-container"

Got clusterization results:

function_key=$(az functionapp keys list --name ks-kristina-function-app --resource-group kristina-test --subscription XXX --query functionKeys -o tsv)
curl --fail https://ks-kristina-function-app.azurewebsites.net/api/status\?code\=$function_key -H "Content-Type:application/json" -d '{"type": "progress"}' | jq

{
  "ready_for_clusterization": null,
  "progress": {
    "ks-kristina-backend000000": [
      "13:17:29 UTC: Running init script",
      "13:17:39 UTC: Downloading weka install script",
      "13:17:40 UTC: Installing weka",
      "13:20:26 UTC: Weka software installation completed",
      "13:20:51 UTC: Weka containers are ready",
      "13:20:52 UTC: This (ks-kristina-vmss_0:ks-kristina-backend000000:4.246.221.221) is instance 2/6 that is ready for clusterization",
      "13:22:47 UTC: Deletion protection was set successfully"
    ],
    "ks-kristina-backend000001": [
      "13:17:31 UTC: Running init script",
      "13:17:41 UTC: Downloading weka install script",
      "13:17:44 UTC: Installing weka",
      "13:20:26 UTC: Weka software installation completed",
      "13:20:52 UTC: Weka containers are ready",
      "13:20:53 UTC: This (ks-kristina-vmss_1:ks-kristina-backend000001:4.246.222.18) is instance 3/6 that is ready for clusterization",
      "13:22:50 UTC: Deletion protection was set successfully"
    ],
    "ks-kristina-backend000002": [
      "13:17:32 UTC: Running init script",
      "13:17:43 UTC: Downloading weka install script",
      "13:17:45 UTC: Installing weka",
      "13:20:40 UTC: Weka software installation completed",
      "13:21:07 UTC: Weka containers are ready",
      "13:21:09 UTC: This (ks-kristina-backend000002) is instance 6 that is ready for clusterization",
      "13:21:09 UTC: Running Clusterization",
      "13:21:22 UTC: Deployment user was created successfully",
      "13:21:52 UTC: Adding drives",
      "13:22:10 UTC: Running start-io",
      "13:22:52 UTC: Deletion protection was set successfully",
      "13:22:56 UTC: Default FS was created successfully",
      "13:22:57 UTC: Clusterization completed successfully"
    ],
    "ks-kristina-backend000003": [
      "13:17:31 UTC: Running init script",
      "13:17:42 UTC: Downloading weka install script",
      "13:17:42 UTC: Installing weka",
      "13:20:25 UTC: Weka software installation completed",
      "13:20:51 UTC: Weka containers are ready",
      "13:20:52 UTC: This (ks-kristina-vmss_3:ks-kristina-backend000003:52.191.51.208) is instance 1/6 that is ready for clusterization",
      "13:22:53 UTC: Deletion protection was set successfully"
    ],
    "ks-kristina-backend000004": [
      "13:17:29 UTC: Running init script",
      "13:17:40 UTC: Downloading weka install script",
      "13:17:40 UTC: Installing weka",
      "13:20:26 UTC: Weka software installation completed",
      "13:20:53 UTC: Weka containers are ready",
      "13:20:54 UTC: This (ks-kristina-vmss_4:ks-kristina-backend000004:52.191.54.73) is instance 5/6 that is ready for clusterization",
      "13:22:55 UTC: Deletion protection was set successfully"
    ],
    "ks-kristina-backend000005": [
      "13:17:33 UTC: Running init script",
      "13:17:43 UTC: Downloading weka install script",
      "13:17:44 UTC: Installing weka",
      "13:20:25 UTC: Weka software installation completed",
      "13:20:52 UTC: Weka containers are ready",
      "13:20:54 UTC: This (ks-kristina-vmss_5:ks-kristina-backend000005:52.191.53.52) is instance 4/6 that is ready for clusterization",
      "13:22:57 UTC: Deletion protection was set successfully"
    ]
  },
  "errors": {
    "ks-kristina-backend000002": [
      "13:22:58 UTC: OBS setup failed"
    ],
    "ks-kristina-vmss_2:ks-kristina-backend000002:4.246.222.14": [
      "13:21:08 UTC: failed to create storage account: PUT https://management.azure.com/subscriptions/d2f248b9-d054-477f-b7e8-413921532c2a/resourceGroups/kristina-test/providers/Microsoft.Storage/storageAccounts/kswekaobs\n--------------------------------------------------------------------------------\nRESPONSE 409: 409 Conflict\nERROR CODE: InvalidResourceLocation\n--------------------------------------------------------------------------------\n{\n  \"error\": {\n    \"code\": \"InvalidResourceLocation\",\n    \"message\": \"The resource 'kswekaobs' already exists in location 'westeurope' in resource group 'kristina-test'. A resource with the same name cannot be created in location 'eastus'. Please select a new resource name.\"\n  }\n}\n--------------------------------------------------------------------------------\n"
    ]
  },
  "debug": {
    "ks-kristina-vmss_2:ks-kristina-backend000002:4.246.222.14": [
      "13:21:08 UTC: creating OBS as no access key was provided"
    ]
  },
  "in_progress": null,
  "summary": {
    "ready_for_clusterization": 0,
    "stopped": 0,
    "in_progress": 0,
    "unknown": null,
    "clusterization_target": 6,
    "clusterization_instance": "",
    "clusterized": true
  }
}

@kristina-solovyova kristina-solovyova marked this pull request as draft March 12, 2025 18:49
@kristina-solovyova kristina-solovyova force-pushed the improve-error-messages-for-storage-account-creation-flow branch from 423810a to 47cb18e Compare March 23, 2025 13:26
@kristina-solovyova kristina-solovyova marked this pull request as ready for review March 23, 2025 13:29
@assafgi assafgi merged commit 04b6bae into dev Apr 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants