Skip to content

fix: obs creation for disabled storage network access and existing pe #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kristina-solovyova
Copy link
Contributor

@kristina-solovyova kristina-solovyova commented Aug 21, 2024

For storage_account_public_network_access = "Disabled" and tiering_enable_obs_integration = true:

  • create_storage_account_private_links = true:
    • no existing OBS - function app creates OBS storage account, container and private endpoints
    • existing OBS - TF creates private endpoint for OBS
  • create_storage_account_private_links = false:
    • no existing OBS - skip OBS setup and report error in status progress
    • existing OBS - clusterization fails on OBS setup step (no access) if there are no existing private endpoints

@kristina-solovyova kristina-solovyova marked this pull request as draft August 21, 2024 09:02
@kristina-solovyova kristina-solovyova force-pushed the fix-obs-creation-for-disabled-network-access-with-existing-pe branch 3 times, most recently from 1887ab3 to f2d083a Compare August 21, 2024 14:46
@kristina-solovyova kristina-solovyova force-pushed the fix-obs-creation-for-disabled-network-access-with-existing-pe branch from f2d083a to 3191b0b Compare August 21, 2024 15:06
@kristina-solovyova kristina-solovyova marked this pull request as ready for review August 21, 2024 15:11
@assafgi assafgi merged commit 545f2c3 into dev Aug 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants