Skip to content

experimental: Support video upload for animations #5144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2025
Merged

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Apr 19, 2025

Description

NEXT PR, TODO, Image Manager accept issue

// https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/accept

Current PR

Not tested but should work with following video files (only mp4 was tested)

  [".mp4", "video/mp4"],
  [".webm", "video/webm"],
  [".mpg", "video/mpeg"],
  [".mpeg", "video/mpeg"],
  [".mov", "video/quicktime"],

How it works

Add Animation Group
Add 1 animation and set ranges
Add Video Animation
Set Source property at Video Animation/Video to uploaded video

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof changed the title experimental: Support video upload experimental: Support video upload for animations Apr 19, 2025
@istarkov istarkov marked this pull request as ready for review April 19, 2025 10:11
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested:

  • uploading mp4
  • getting image preview from a video url

@istarkov istarkov merged commit 4138a56 into main Apr 21, 2025
53 checks passed
@istarkov istarkov deleted the video.staging branch April 21, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants