Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use consistent naming of the meta key #5069

Merged
merged 1 commit into from
Mar 28, 2025
Merged

refactor: Use consistent naming of the meta key #5069

merged 1 commit into from
Mar 28, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 28, 2025

Description

We are using "meta" in commands, but "cmd" in Kbd, now this is consistently called "meta" everywhere.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound March 28, 2025 11:01
@kof kof temporarily deployed to development March 28, 2025 11:06 — with GitHub Actions Inactive
@kof kof merged commit 07fbc3b into main Mar 28, 2025
17 checks passed
@kof kof deleted the meta-key branch March 28, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants