Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Stagger Animation #5066

Merged
merged 15 commits into from
Mar 30, 2025
Merged

experimental: Stagger Animation #5066

merged 15 commits into from
Mar 30, 2025

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Mar 28, 2025

Description

https://p-1ada14ed-beb3-4910-8af1-dacaa550310b-dot-stager.staging.webstudio.is/?pageId=5bx4prWBtn925kuZPcetS&authToken=1e621fc4-dfb0-4189-a9b0-4fe2e189ec93&mode=preview

https://animations.wstd.work/intermediate-staggering

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov marked this pull request as ready for review March 29, 2025 06:02
@istarkov istarkov requested review from kof and Copilot March 29, 2025 06:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an experimental Stagger Animation component to enhance animation handling in the SDK. Key changes include:

  • Adding a new StaggerAnimation meta and props definition.
  • Introducing the experimental StaggerAnimation component with its associated TypeScript file.
  • Updating export modules and augmenting documentation in the animate-text component for consistency.

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
packages/sdk-components-animation/src/stagger-animation.ws.ts Adds meta and propsMeta for the new StaggerAnimation component.
packages/sdk-components-animation/src/stagger-animation.tsx Implements the new StaggerAnimation component as a forwardRef.
packages/sdk-components-animation/src/props.ts Exports the new StaggerAnimation props meta.
packages/sdk-components-animation/src/metas.ts Exports the new StaggerAnimation meta.
packages/sdk-components-animation/src/components.ts Exports the new StaggerAnimation component.
packages/sdk-components-animation/src/animate-text.tsx Updates prop comments to include slidingWindow and easing details.
Files not reviewed (3)
  • packages/sdk-components-animation/private-src: Language not supported
  • packages/sdk-components-animation/src/generated/animate-text.props.ts: Language not supported
  • packages/sdk-components-animation/src/generated/stagger-animation.props.ts: Language not supported
Comments suppressed due to low confidence (1)

packages/sdk-components-animation/src/stagger-animation.ws.ts:14

  • Verify that constraining the StaggerAnimation component to only accept an AnimateChildren parent is intentional, as it may restrict its usage in cases where a more flexible parent might be required.
{ relation: "parent", component: { $eq: "AnimateChildren" } },

@istarkov istarkov merged commit 3f5041a into main Mar 30, 2025
29 checks passed
@istarkov istarkov deleted the stager.staging branch March 30, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants