-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: Stagger Animation #5066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an experimental Stagger Animation component to enhance animation handling in the SDK. Key changes include:
- Adding a new StaggerAnimation meta and props definition.
- Introducing the experimental StaggerAnimation component with its associated TypeScript file.
- Updating export modules and augmenting documentation in the animate-text component for consistency.
Reviewed Changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
packages/sdk-components-animation/src/stagger-animation.ws.ts | Adds meta and propsMeta for the new StaggerAnimation component. |
packages/sdk-components-animation/src/stagger-animation.tsx | Implements the new StaggerAnimation component as a forwardRef. |
packages/sdk-components-animation/src/props.ts | Exports the new StaggerAnimation props meta. |
packages/sdk-components-animation/src/metas.ts | Exports the new StaggerAnimation meta. |
packages/sdk-components-animation/src/components.ts | Exports the new StaggerAnimation component. |
packages/sdk-components-animation/src/animate-text.tsx | Updates prop comments to include slidingWindow and easing details. |
Files not reviewed (3)
- packages/sdk-components-animation/private-src: Language not supported
- packages/sdk-components-animation/src/generated/animate-text.props.ts: Language not supported
- packages/sdk-components-animation/src/generated/stagger-animation.props.ts: Language not supported
Comments suppressed due to low confidence (1)
packages/sdk-components-animation/src/stagger-animation.ws.ts:14
- Verify that constraining the StaggerAnimation component to only accept an AnimateChildren parent is intentional, as it may restrict its usage in cases where a more flexible parent might be required.
{ relation: "parent", component: { $eq: "AnimateChildren" } },
TrySound
reviewed
Mar 29, 2025
kof
approved these changes
Mar 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://p-1ada14ed-beb3-4910-8af1-dacaa550310b-dot-stager.staging.webstudio.is/?pageId=5bx4prWBtn925kuZPcetS&authToken=1e621fc4-dfb0-4189-a9b0-4fe2e189ec93&mode=preview
https://animations.wstd.work/intermediate-staggering
Steps for reproduction
Code Review
Before requesting a review
Before merging
.env
file