Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow creating variables when input starts with dashes in advanced style section #5051

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 25, 2025

Description

We broke this as we introduced a more flexible search to combobox when you add properties

Steps for reproduction

  1. advanced panel
  2. type --x
  3. see you can create that variable right away without adding value

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound March 25, 2025 21:12
@kof kof merged commit 9d298cc into main Mar 26, 2025
17 checks passed
@kof kof deleted the css-var-fix branch March 26, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants