Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix add style input focus when pressing + button #5047

Merged
merged 1 commit into from
Mar 25, 2025
Merged

fix: Fix add style input focus when pressing + button #5047

merged 1 commit into from
Mar 25, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 25, 2025

Steps for reproduction

  1. go to advanced
  2. click + button - focus should happen
  3. click again - it will quickly disappear and appear focused again - this is expected
  4. hit enter or tab on recently added value - input will appear focused

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof merged commit 2f59404 into main Mar 25, 2025
17 checks passed
@kof kof deleted the fix-focus branch March 25, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants