Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Fix chrome 134 regression bug #5046

Merged
merged 5 commits into from
Mar 26, 2025
Merged

experimental: Fix chrome 134 regression bug #5046

merged 5 commits into from
Mar 26, 2025

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Mar 25, 2025

Description

https://issues.chromium.org/issues/403708813

Steps for reproduction

Type in Debug Console
ScrollTimeline
for Chrome 134.0.6998.164 >= version >= 134.0.6998.0
This would be non native code

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from TrySound March 25, 2025 14:09
@istarkov istarkov marked this pull request as ready for review March 25, 2025 14:10
@istarkov istarkov merged commit b787e3d into main Mar 26, 2025
29 checks passed
@istarkov istarkov deleted the chr134.staging branch March 26, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant