Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Enable/disable animations per breakpoints (Builder UI only) #5010

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Mar 17, 2025

Description

!! Builder UI only !!

Enable/disable animations per breakpoints.

image

Next PR:

Component support

Steps for reproduction

Disable animation at some breakpoint. See in builder UI it's disabled for all corresponding breakpoints too.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov changed the title experimental: Enable/disable animations per breakpoints experimental: Enable/disable animations per breakpoints (Builder UI only) Mar 17, 2025
@istarkov istarkov requested a review from TrySound March 17, 2025 14:55
@istarkov istarkov marked this pull request as ready for review March 17, 2025 14:56
@istarkov istarkov merged commit 9e77277 into main Mar 18, 2025
17 checks passed
@istarkov istarkov deleted the eye-ui branch March 18, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants