Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore focus after closing dropdown via Esc in CSS Value input #5002

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 14, 2025

Description

Steps for reproduction

  1. focus any style value
  2. type to open dropdown
  3. hit ESC
  4. see the input is still focused
  5. hit ESC again
  6. see the change is resetted

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov merged commit 2bb6e9d into main Mar 15, 2025
17 checks passed
@istarkov istarkov deleted the fix-esc branch March 15, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants