Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sicky search input for advanced styles section #4998

Merged
merged 10 commits into from
Mar 15, 2025
Merged

feat: Sicky search input for advanced styles section #4998

merged 10 commits into from
Mar 15, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 13, 2025

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili March 13, 2025 23:33
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too problematic. That massive gap is the thing that needs to change imo. Unless search sets scroll back to top but IMO the blank space is the issue.

search.mp4

This pattern will be common btw... scroll for something, then decide to search

@kof kof requested a review from johnsicili March 14, 2025 12:23
@kof kof requested a review from TrySound March 15, 2025 16:08
@kof kof merged commit abb3572 into main Mar 15, 2025
17 checks passed
@kof kof deleted the sticky-search branch March 15, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants