Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes saving binding when closing popover by click outside #4941

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

kof
Copy link
Member

@kof kof commented Mar 4, 2025

Description

image

When you are creating a binding from inside a variable dialog and having popover opened from a popover, when you click outside, binding won't be saved

Steps for reproduction

  1. create resource variable
  2. close
  3. edit that variabel
  4. bind url
  5. click outside of both popovers
  6. see changes were saved

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from istarkov and TrySound March 4, 2025 15:39
@kof kof merged commit e9ca015 into main Mar 6, 2025
17 checks passed
@kof kof deleted the fix-save-binidng branch March 6, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants