Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix local token clickable area #4922

Merged
merged 2 commits into from
Feb 27, 2025
Merged

fix: Fix local token clickable area #4922

merged 2 commits into from
Feb 27, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 27, 2025

Description

  1. Local token clickable area is now the entire button surface, closes Local button is smaller than Local hover area causing misclicks #4864
  2. When editing token name, now local doesn't jump around

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from istarkov February 27, 2025 13:27
@kof kof removed the request for review from istarkov February 27, 2025 14:13
@kof kof merged commit 47e15ab into main Feb 27, 2025
19 checks passed
@kof kof deleted the fix-local-token-size branch February 27, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local button is smaller than Local hover area causing misclicks
3 participants