Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Backspace to reset the value in CSS Value Input #4878

Merged
merged 5 commits into from
Feb 15, 2025
Merged

Conversation

kof
Copy link
Member

@kof kof commented Feb 15, 2025

Description

  1. improved composeEventHandlers implementation
  2. delete value text, then hit backspace - same as reset
  3. in advanced panel all property tooltips now show "Delete property" wording instead of "Reset value"
image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof changed the title feat: CSS Value Input now allows to hit Backspace to reset the value feat: Backspace to reset the value in CSS Value Input Feb 15, 2025
@kof kof requested review from istarkov and johnsicili February 15, 2025 16:05
@kof kof marked this pull request as ready for review February 15, 2025 16:05
@kof kof merged commit 6eb989d into main Feb 15, 2025
17 checks passed
@kof kof deleted the css-value-bsp branch February 15, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants