Skip to content

experimental: Improve readability in advanced section #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2025
Merged

experimental: Improve readability in advanced section #4852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
574d6be
improve readability in advanced section
kof Feb 10, 2025
bba69c4
fix indentation evenly
kof Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions apps/builder/app/builder/features/style-panel/sections/advanced/advanced.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,10 @@ const AddProperty = forwardRef<
);
});

// Used to indent the values when they are on the next line. This way its easier to see
// where the property ends and value begins, especially in case of presets.
const indentation = `20px`;

const AdvancedPropertyLabel = ({
property,
onReset,
Expand Down Expand Up @@ -334,6 +338,7 @@ const AdvancedPropertyLabel = ({
text="mono"
css={{
backgroundColor: "transparent",
marginLeft: `-${indentation}`,
}}
>
{label}
Expand Down Expand Up @@ -542,6 +547,7 @@ const AdvancedProperty = memo(
// with "auto" it will call it with skipped false for all initial elements.
// 44px is the height of the property row with 2 lines of text. This value can be adjusted slightly.
containIntrinsicSize: "auto 44px",
paddingLeft: indentation,
}}
key={property}
wrap="wrap"
Expand All @@ -551,12 +557,20 @@ const AdvancedProperty = memo(
{isVisible && (
<>
<AdvancedPropertyLabel property={property} onReset={onReset} />
<Text>:</Text>
<AdvancedPropertyValue
autoFocus={autoFocus}
property={property}
onChangeComplete={onChangeComplete}
/>
<Text
variant="mono"
// Improves the visual separation of value from the property.
css={{ textIndent: "-0.5ch", fontWeight: "bold" }}
>
:
</Text>
<Box css={{ color: "red" }}>
<AdvancedPropertyValue
autoFocus={autoFocus}
property={property}
onChangeComplete={onChangeComplete}
/>
</Box>
</>
)}
</Flex>
Expand Down
2 changes: 1 addition & 1 deletion packages/design-system/src/components/label.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ const StyledLabel = styled(RadixLabel, {
},
preset: {
backgroundColor: theme.colors.backgroundPresetMain,
color: theme.colors.foregroundMain,
color: theme.colors.foregroundTextSubtle,
"&:hover": {
backgroundColor: theme.colors.backgroundPresetHover,
},
Expand Down
Loading