Skip to content

refactor: generate stories for base components #4734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 10, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/sdk-cli/src/generate-stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,15 @@ import {
WsComponentMeta,
} from "@webstudio-is/sdk";
import {
coreMetas,
generateCss,
generateWebstudioComponent,
getIndexesWithinAncestors,
namespaceMeta,
} from "@webstudio-is/react-sdk";
import { renderTemplate, type TemplateMeta } from "@webstudio-is/template";

const WS_NAMESPACE = "ws";
const BASE_NAMESPACE = "@webstudio-is/sdk-components-react";

const generateComponentImports = ({
Expand Down Expand Up @@ -53,6 +55,9 @@ const generateComponentImports = ({

let componentImports = "";
for (const [namespace, componentsSet] of namespaces.entries()) {
if (namespace === WS_NAMESPACE) {
continue;
}
const specifiers = Array.from(componentsSet)
.map(
([shortName, component]) =>
Expand Down Expand Up @@ -135,7 +140,9 @@ export const generateStories = async () => {
const usedMetas = new Map<string, WsComponentMeta>();
for (const namespace of namespaces) {
let namespaceMetas;
if (namespace === packageJson.name) {
if (namespace === WS_NAMESPACE) {
namespaceMetas = new Map(Object.entries(coreMetas));
} else if (namespace === packageJson.name) {
namespaceMetas = metas;
} else {
const metasUrl = import.meta.resolve(
Expand All @@ -145,7 +152,7 @@ export const generateStories = async () => {
namespaceMetas = new Map(Object.entries(await import(metasUrl)));
}
for (let [name, meta] of namespaceMetas) {
if (namespace !== BASE_NAMESPACE) {
if (namespace !== BASE_NAMESPACE && namespace !== WS_NAMESPACE) {
name = `${namespace}:${name}`;
meta = namespaceMeta(
meta as WsComponentMeta,
Expand Down
2 changes: 2 additions & 0 deletions packages/sdk-components-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
"scripts": {
"build": "vite build --config ../../vite.sdk-components.config.ts",
"build:args": "NODE_OPTIONS=--conditions=webstudio generate-arg-types './src/*.tsx !./src/*.stories.tsx !./src/*.test.{ts,tsx} !./src/*.ws.ts !./src/*.ws.ts !./src/*.template.tsx' && prettier --write \"**/*.props.ts\"",
"build:stories": "webstudio-sdk generate-stories && prettier --write \"src/__generated__/*.stories.tsx\"",
"dts": "tsc --project tsconfig.dts.json",
"test": "vitest run",
"typecheck": "tsc"
Expand All @@ -66,6 +67,7 @@
"@types/react": "^18.2.70",
"@types/react-dom": "^18.2.25",
"@webstudio-is/generate-arg-types": "workspace:*",
"@webstudio-is/sdk-cli": "workspace:*",
"@webstudio-is/template": "workspace:*",
"@webstudio-is/tsconfig": "workspace:*",
"react": "18.3.0-canary-14898b6a9-20240318",
Expand Down
123 changes: 123 additions & 0 deletions packages/sdk-components-react/src/__generated__/blockquote.stories.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

128 changes: 128 additions & 0 deletions packages/sdk-components-react/src/__generated__/button.stories.tsx

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading