refactor: fallback missing pages to home page #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With undo current selected pages can be deleted though we do not have a logic reverting selected page or instance. So here is quick fix to always fallback to home page if pageId in url references missing page.
kof
approved these changes
Dec 16, 2024
TrySound
added a commit
that referenced
this pull request
Dec 17, 2024
See https://discord.com/channels/955905230107738152/1318274135679438959/1318274135679438959 With undo current selected pages can be deleted though we do not have a logic reverting selected page or instance. So here is quick fix to always fallback to home page if pageId in url references missing page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discord.com/channels/955905230107738152/1318274135679438959/1318274135679438959
With undo current selected pages can be deleted
though we do not have a logic reverting selected page or instance.
So here is quick fix to always fallback to home page if pageId in url references missing page.