Skip to content

experimental: Commands UI design tweaks #4594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 16, 2024
Merged

experimental: Commands UI design tweaks #4594

merged 5 commits into from
Dec 16, 2024

Conversation

kof
Copy link
Member

@kof kof commented Dec 16, 2024

Description

  • Bigger border radius for the dialog and floating panels as well for consistency
  • Bigger search container height, same as titles in dialogs

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested review from TrySound and johnsicili December 16, 2024 12:10
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Drag handles are a little to close to the edge imo but very minor

Screenshot 2024-12-16 at 7 01 17 AM

@kof kof requested a review from TrySound December 16, 2024 14:05
@kof kof merged commit c779a8e into main Dec 16, 2024
15 checks passed
@kof kof deleted the commands-design branch December 16, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants