Skip to content

fix: Speedup resize, part 1 #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix: Speedup resize, part 1 #4543

merged 1 commit into from
Dec 10, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 10, 2024

Description

Removes rerender of the whole builder during resize.

Still some debounced resize of style panel etc exists. But will investigate in following PR

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from TrySound December 10, 2024 04:45
@istarkov istarkov merged commit cd4041e into main Dec 10, 2024
17 checks passed
@istarkov istarkov deleted the speedup-resize branch December 10, 2024 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants