perf: generate html react props from html spec #2341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
TrySound
changed the title
Here scraped html spec to generate attributes per tag and added converter to out props meta format. In the next PR will reuse for settings panel and remove html attributes from generated comomponent props. Having html attributes not tied to specific framework will let us generate formats compatible with any framework.
TrySound
force-pushed
the
generate-html-props
branch
from
220e598 to
7ae1991
Compare
kof
reviewed
Sep 22, 2023
| import type { Attribute, AttributesByTag } from "./types"; | ||
| import { htmlPropsDescriptions } from "./descriptions"; | ||
|
|
||
| // scrub attributes data from https://html.spec.whatwg.org/multipage/indices.html#attributes-3 |
There was a problem hiding this comment.
wasn't this available in mdn-data package? or some other package? I know entire HTML spec is in jsons at this point, even the official spec has a repo, scraping that stuff seems fragile
TrySound
added a commit
that referenced
this pull request
Apr 21, 2025
Here added lists of attributes from html and aria specifications for future Element component. Html provides an easy to navigate table with all types with relations to specific tags and descriptions. Aria list with types is extracted from aria-query library. Though descriptions are parsed from specification. In the future we will use more aria-query data to navigate specific roles. All attributes types are tested with react types You can see generated data in - packages/html-data/src/__generated__/attributes.ts - packages/html-data/src/__generated__/aria.ts Succeeds #2341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here scraped html spec to generate attributes per tag and added converter to out props meta format.
In the next PR will reuse for settings panel and remove html attributes from generated comomponent props.
Having html attributes not tied to specific framework will let us generate formats compatible with any framework.
Code Review
Before requesting a review
Before merging
.env.exampleand thebuilder/env-check.jsif mandatory