Smarter query string for client entry, also works for script

[syranide]

My use-case is that I require HTTPS and have set-up an nginx proxy in a directory /webpack-dev-server/ for webpack-dev-server. This allows me to use certificates and basically pretend that webpack-dev-server doesn't exist. However, /socket.io/ is "hard-coded" and cannot be changed currently, this allows it to be replaced with any URL.

This PR significantly improves the query string and also enables it for the script tag.

Currently, the only supported syntax is:
'webpack-dev-server/client?http://domain'
... /socket.io is implicit.

This adds support for paths:
'webpack-dev-server/client?https://domain/webpack-dev-server/socket.io'
... /socket.io is no longer implicit when a path is present.

It also adds support for relative paths:
'webpack-dev-server/client?/webpack-dev-server/socket.io'
'webpack-dev-server/client?socket.io'
... is equivalent if the bundle is loaded from /webpack-dev-server/bundle.js.

Also, as I mentioned, script tags support the same syntax:
<script src="/webpack-dev-server/bundle.js?http://put.it/somewhere/else/socket.io"></script>

Caution though, I haven't tested this extensively and I haven't tested the script tag at all (but I did test it manually in the code and it seemed fine) as I'm not sure how the index.bundle.js is created. The code is complicated a bit by the fact that URLs are currently required (by webpack-dev-server) to not have a tailing / which is technically incorrect as they really are directories and not files.

👍 for a kick-ass project.

If someone finds it useful, I use the following nginx configuration (the tailing slash for proxy_pass is important!):

  location /<path>/ {
    proxy_http_version 1.1;
    proxy_set_header Upgrade $http_upgrade;
    proxy_set_header Connection "upgrade";
    proxy_pass http://<webpack-dev-server>/;
  }

[syranide]

Ping, I don't mind dropping the relative paths, but I would find great use for the configurable socket.io-path.

Is there something about this PR you don't like/object to?

[sokra]

Sorry, forgot about that...

I think this is unnecessary now. The webpack-dev-server supports HTTPS now and you shouldn't need to proxy it (host it on another port).

Read here about how to setup the webpack-dev-server without proxy: http://webpack.github.io/docs/webpack-dev-server.html#combining-with-an-existing-server

[syranide]

@sokra Ah, using our authority-signed certificate is however mandatory for me (I'm also doing cross-domain stuff). The reason I like the proxy setup is because HMR/WDS can be used transparently (apart from a small path change), serving some assets from a separate server is not without issues, especially when it comes to SWF. So the proxy solution still seems preferable to me.

[sokra]

hmm... ok.

Any why do you want to change the socket.io path? I think it's possible the pass a subpath to the client webpack-dev-server/client?https://domain/some/sub/path. Why the additional /socket.io?

[syranide]

@sokra Because socket.io is always expected to be located at /socket.io/, I cannot put it somewhere else as part of the proxy setup. Which means I can't have more than WDS proxied on the same domain. Being able to move it (one way or another) is the only thing really missing for me.

[syranide]

Closing in-favor of #240