Add quotation to children's input options if required #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theofidry Would be great if you could take a look at it soon, as one of our releases depends on this Update: we are going to do some additional internal tests and will then report the test results here. |
…tation/escaping and simplify / fix regex.
|
Successfully tested: bin/console app:ecommerce:bootstrap --update-index --tenant=AT_de_elastic --processes 1 --list-condition='o_id in ("20") or o_id > 5000000'
bin/console app:ecommerce:bootstrap --update-index --tenant=AT_de_elastic --processes 1 --list-condition="o_id in ('20') or o_id > 5000000"
bin/console app:ecommerce:bootstrap --update-index --tenant=AT_de_elastic --processes 1 --list-condition="o_id in (\"20\") or o_id > 5000000"PR should be ready. |
|
Thank you @andreas-gruenwald |
theofidry
added a commit
that referenced
this pull request
Sep 30, 2022
In #28, the feature to forward the command options was introduced. It had to later be followed up by #41, #42 in order to fix the issue where the option value may require quoting. This piece of code is heavily under-tested (and it was really hard to test it as is) and is prone to bugs (I found 2 adding tests). In this PR, I'm extracting this element into `InputOptionsSerializer` as a closed piece (static & final) as IMO there is no need to make it extensible: if broken it needs to be fixed. This extraction allows much easier testing. This PR also fixes: - the case of negatable options - detection quoting with may fail to detect some special characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #41