Skip to content

tag preprocessor example in readme results in an error #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlskoeser opened this issue Sep 3, 2021 · 1 comment
Closed

tag preprocessor example in readme results in an error #39

rlskoeser opened this issue Sep 3, 2021 · 1 comment

Comments

@rlskoeser
Copy link
Contributor

the readme includes this example usage under the annotation preprocessors section:

$ inscript.py https://www.fhgr.ch \
        -r ./examples/annotation-profile.json \
        -p tag

When I try running it, I get this error:

ModuleNotFoundError: No module named 'inscriptis.annotation.output.tag'

It's not clear from the example whether it's meant to be a placeholder command or a real one (I think the first?); maybe just revise it to use an actual supported preprocessor to avoid confusion

AlbertWeichselbraun added a commit that referenced this issue Sep 6, 2021
- corrected the name of the annotation preprocessor from `tag` to `surface`.
@AlbertWeichselbraun
Copy link
Contributor

Thanks for spotting this - I forgot to update the preprocessor name (tag has been the old name for the surface preprocessor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants