-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Management/Admin scripts for the project #971
Conversation
ah interesting. One thing I don't know the answer is that if there is a constraint for requirements.txt to be in the root directory. apart of that it's fine for me. @magsout once you moved requirements.txt, does the project restart well? I wonderf what is happening for example with |
maybe just managed path here https://github.com/webcompat/webcompat.com/blob/master/run.py#L77 ? no ? Let me test.. Honestly I ddin't test anyhting about it, recipes only ... 🐰 |
@karlcow I modified path in run.py and that's ok |
cc3ddf0
to
7157178
Compare
Moving |
But +1 from me, I've been using npm scripts in another small project. |
@@ -36,7 +36,7 @@ before_install: | |||
install: | |||
- travis_retry npm install -g grunt-cli | |||
- travis_retry npm install | |||
- travis_retry pip install -r requirements.txt --download-cache $HOME/.pip-cache | |||
- travis_retry pip install -r config/requirements.txt --download-cache $HOME/.pip-cache |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
@magsout the docs that need to be updated are here: https://github.com/webcompat/webcompat.com/blob/master/CONTRIBUTING.md#installing-project-source-code r+ from me. Let's let @karlcow give the final +1. |
Need to figure out how npm travis script can be used to test the installation works well. perhaps decompose even in the script package.json
Yes, of course, I waited that my idea looks good for you ;) |
@magsout yup looks good. I'm not a big fan of having to use package.json for the recipes, but I can live with it. :) I would have personally used something in python, but not very important. Thanks! 🍰 |
In many project with have node and package.json, So I guess wen can say it's universal ? ;p
just replace all npm run watch
npm run build
npm run start |
Updated @karlcow @miketaylr What do you think about all recipes ? Revelant ? Clear ? |
@@ -38,5 +38,64 @@ | |||
"postcss-url": "^5.1.1", | |||
"suitcss-utils-align": "^0.2.0", | |||
"suitcss-utils-display": "^0.4.0" | |||
}, | |||
"scripts": { | |||
"init": "npm run module && npm run virtualenv && && npm run pip && npm install && npm run config", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
Yep, LGTM except for the one small |
@magsout looks good to me. |
OOoOps |
Karl gave his r+. So let's merge. |
r? @karlcow
wip, just for starting cleaned root folder, what do you think ?
Makefile
because it's device agnostic (unix only) and add all recipes directly inpackage.json
I like this convention to add all recipes in one place.eslint
and added all rules inpackage.json
requirement.txt
for now inconfig
folderwebcompat.sh