Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #913 - fixed overflow <code> and <pre> #917

Merged
merged 1 commit into from
Feb 9, 2016
Merged

Conversation

magsout
Copy link
Member

@magsout magsout commented Feb 8, 2016

Close #913

capture d ecran 2016-02-08 a 12 15 37

r? @karlcow

@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

ok let's see

git checkout -b comment-overflow upstream/comment-overflow
git status
# On branch comment-overflow
# Your branch is up-to-date with 'upstream/comment-overflow'.
# nothing to commit, working directory clean
grunt
# >> Local Npm module "grunt-eslint" not found. Is it installed?
# Warning: Task "eslint" not found. Use --force to continue.
#
# Aborted due to warnings.

ok I guess I need to update a couple of things.
We probably need to adjust the documentation.

make update
#
#
grunt
#
# Done, without errors.

ok. :)

python run.py
# secrets /Users/karl/code/webcompat.com
# * Running on http://localhost:5000/ (Press CTRL+C to quit)
# * Restarting with stat
# secrets /Users/karl/code/webcompat.com
#
#
# 127.0.0.1 - - [09/Feb/2016 15:19:56] "GET /api/issues/labels?per_page=100 HTTP/1.1" 404 -
# 127.0.0.1 - - [09/Feb/2016 15:19:57] "GET /api/issues/category/new HTTP/1.1" 404 -

huh.

http HEAD http://localhost:5000/api/issues/category/new

grmbl.

HTTP/1.0 404 NOT FOUND
Content-Length: 5784
Content-Type: text/html; charset=utf-8
Date: Tue, 09 Feb 2016 06:25:26 GMT
Server: Werkzeug/0.10.4 Python/2.7.10

Something has changed in the project.

@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

ah interesting.

→ make start
❯ Starting...
secrets /Users/karl/code/webcompat.com
Traceback (most recent call last):
  File "run.py", line 38, in <module>
    raise ImportError('{0}\n\n{1}'.format(e, IMPORT_ERROR))
ImportError: No module named flask_wtf.file


==============================================
It seems like you don't have all dependencies.
Please re-run:
    pip install -r requirements.txt
==============================================

make: *** [start] Error 1

but

python run.py

doesn't send an error message.

and doing

pip install -r requirements.txt

doesn't solve it.

@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

ok my bad, I had forgotten about
ISSUES_REPO_URI = os.environ.get('ISSUES_REPO_URI') or 'webcompat/webcompat-tests/issues'

btw the doc need to be changed.

let's go back on track.

karlcow added a commit that referenced this pull request Feb 9, 2016
fix #913 - fixed overflow <code> and <pre>
@karlcow karlcow merged commit d5ff763 into master Feb 9, 2016
@karlcow
Copy link
Member

karlcow commented Feb 9, 2016

ok this is fixed. @magsout
r+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants