Issue #848 - Add style to cssfixme service #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@miketaylr why I have to restart build each time ? if not, travis are not happy |
I need to figure that out.... :( something weird about the search tests that fail every-other-time... |
|
r+, looks so much better! |
miketaylr
pushed a commit
that referenced
this pull request
Dec 29, 2015
Issue #848 - Add style to cssfixme service
miketaylr
added
status: add to changelog
status: in progress
and removed
status: in progress
needs-review
labels
|
r+ with minor suggestions on the prose organization. Something along these lines Let's put the big pile of text at the end of the page. |
|
Nice @karlcow . What about output (résultat) ? Between Button and the text ? |
|
Yes the output should come between the button and the text. Basically the text is always at the bottom. |
|
ok @karlcow good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
We can improve it,it's a lick of paint
r? @karlcow @miketaylr @calexity @hallvors @tagawa