Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SearchBar to HomePage #725

Merged
merged 6 commits into from
Oct 1, 2015
Merged

Added SearchBar to HomePage #725

merged 6 commits into from
Oct 1, 2015

Conversation

magsout
Copy link
Member

@magsout magsout commented Oct 1, 2015

@magsout
Copy link
Member Author

magsout commented Oct 1, 2015

@miketaylr when we click on button js-SearchBarOpenjust add is-active to js-SearchBar and remove it when we click on js-SearchBarClose

@magsout magsout force-pushed the searchBar-on-topbar branch from 779e89f to dd88caa Compare October 1, 2015 08:08
@miketaylr
Copy link
Member

@magsout did we accidentally break the /issues top bar?

@magsout
Copy link
Member Author

magsout commented Oct 1, 2015

ooops 👎

@magsout magsout force-pushed the searchBar-on-topbar branch from 686eceb to dae70ca Compare October 1, 2015 08:55
@magsout
Copy link
Member Author

magsout commented Oct 1, 2015

arg sorry @miketaylr

@magsout
Copy link
Member Author

magsout commented Oct 1, 2015

forced update ... 😭

@magsout
Copy link
Member Author

magsout commented Oct 1, 2015

👯

@magsout
Copy link
Member Author

magsout commented Oct 1, 2015

hbgtv4y

@miketaylr
Copy link
Member

This is awesome. I just need to figure out why only the ?q param appears on the /issues page once you do a search--but I'll open a new bug for that.

miketaylr pushed a commit that referenced this pull request Oct 1, 2015
@miketaylr miketaylr merged commit 97cebce into master Oct 1, 2015
@miketaylr miketaylr deleted the searchBar-on-topbar branch October 1, 2015 09:10
ksy36 added a commit that referenced this pull request May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants