Improve layout qrCode

[magsout]

r? @tagawa

[miketaylr]

It looks like this would close #651 and #649. 👍

[magsout]

just one thing @miketaylr there is one error when I add qrcode.js in the linter about var qrDataUrl = qr.toDataURL({value: this.url, size: 8}); qr is not init, if you can take a look.

[miketaylr]

Will take a look today.

[miketaylr]

@magsout just needed to add qr to the list of allowed globals. All good now.

[miketaylr]

One day we'll move to modules and stop leaking globals everywhere. :P

[miketaylr]

(Don't worry about failing tests here, lots of moving parts unrelated to these changes -- we'll make sure everything is passing before deploying).

[magsout]

😎

[magsout]

One day we'll move to modules and stop leaking globals everywhere. :P

🙏

[magsout]

Ping @tagawa 👌

[tagawa]

Thanks @magsout, will try to look at it later.

[miketaylr]

LGTM. Stealing this from @tagawa, if he doesn't mind.

[tagawa]

Thanks @miketaylr. Sorry — difficult to find time at the moment.
Feel free to "Sacre bleu, les anglais!" and stuff like that.

[magsout]

❤️

[miketaylr]

@tagawa no worries! we all have busy and less busy seasons. 🇬🇧