Fix #373 - Enable Filter dropdown #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 9, 2014 20:24
This way there's wayyyy less string parsing.
With an option to pass it the entire thing, rather than composing from model path and params properties. This is used when following Link header URIs.
Now that we just get the param state from the model, we can update it and let fetchAndRenderIssues do the rest of the work.
|
r? @magsout |
|
Let me deploy to staging so you can play with it. |
|
Deployed to http://staging.webcompat.com/issues |
magsout
added a commit
that referenced
this pull request
Dec 12, 2014
Fix #373 - Enable Filter dropdown
|
Thanks @magsout 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundles in a refactor of how we compute the Issues url and params and gets rid of jQuery.deparam which we no longer need.
I removed the "View issues assigned to me" option from the design mockup because we don't really display what issues are assigned or provide tool to assign issues. So if we do that in the future, we can add it.
With this added, we should probably re-open #416 because I think I changed my mind how that should work. Will put thoughts there.