Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3505 - Remove animations/scrolling for prefers-reduced-motion #3747

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jan 20, 2023

Fixes #3505 (and #3735)

@@ -20,9 +18,6 @@ const handleMessage = (message) => {

sendAnalyticsCS(utm_campaign, utm_source);
if (url) {
showStep("category", {
url: extractPrettyUrl(url),
});
updateUrl(url);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also removed the "skip the url and scroll to the category step" when reporting through "Report site issue". It was part of the experiment to try and improve the form drop off. Thinking it might be confusing for new users as it happens immediately, skipping the part that we're looking for web compatibility issues (and "Learn more about web compatibility" pop up) .

@ksy36 ksy36 requested a review from denschub January 20, 2023 16:46
@ksy36 ksy36 marked this pull request as ready for review January 20, 2023 16:46
@ksy36
Copy link
Contributor Author

ksy36 commented Jan 20, 2023

r? @denschub

@@ -8,4 +8,3 @@
<p>You can return to this web page at any time to track the progress of this report.</p>
</section>
</script>
˚
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

Copy link
Member

@denschub denschub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@ksy36 ksy36 merged commit e051194 into main Jan 27, 2023
@ksy36 ksy36 deleted the issue/3505/1 branch January 27, 2023 16:38
@ksy36
Copy link
Contributor Author

ksy36 commented Jan 27, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11Y] Bug report form can trigger migraines and motion sickness for users with visual or vestibular issues
2 participants