fix #3114 - Fix excessive labels assignment

[karlcow]

This PR fixes issue #3114

Proposed PR background

This switches the strategy for assigning labels.
We will control a bit more what is done.

[karlcow]

Do not merge. Just pushing for the PR to run the tests.

[ksy36]

Thanks, looks good!

[ksy36]

There is an error when editing labels/milestone for users with write access (however the change is applied):

  File "/Users/ksenia/Documents/projects/webcompat.com/webcompat/api/endpoints.py", line 69, in edit_issue
    print(edit.status_code, 'test')
AttributeError: 'tuple' object has no attribute 'status_code'

I'll create a PR with a fix

[karlcow]

ok. I think I understand the issue.
So we replaced proxy_request by api_request, but this too doesn't return a regular object (bad design, we need to fix this, but probably in a separate bug).

webcompat.com/webcompat/helpers.py

Lines 459 to 481 in e5dbd1c

	@mockable_response
	def api_request(method, path, params=None, data=None, mime_type=JSON_MIME):
	"""Handle communication with the GitHub API.
	This method handles both logged-in and proxied requests.
	This returns a tuple for the convenience of being able to do:
	`return api_request('get', path, params=params)` directly from a view
	function. Flask will turn a tuple of the format
	(content, status_code, response_headers) into a Response object.
	"""
	request_headers = get_request_headers(g.request_headers, mime_type)
	if g.user:
	request_method = github.raw_request
	else:
	request_method = proxy_request
	resource = request_method(method, path, headers=request_headers,
	params=params, data=data)
	if resource.status_code != 404:
	return (resource.content, resource.status_code,
	get_response_headers(resource))
	else:
	abort(404)

webcompat.com/webcompat/helpers.py

Lines 436 to 456 in e5dbd1c

	@mockable_response
	def proxy_request(method, path, params=None, headers=None, data=None):
	"""Make a GitHub API request with a bot's OAuth token.
	Necessary for non-logged in users.
	* `path` will be appended to the end of the API_URI.
	* Optionally pass in POST data via the `data` arg.
	* Optionally point to a different URI via the `uri` arg.
	* Optionally pass in HTTP headers to forward.
	"""
	# Merge passed in headers with AUTH_HEADERS, and add the etag of the
	# request, if it exists, to be sent back to GitHub.
	auth_headers = AUTH_HEADERS.copy()
	if headers:
	auth_headers.update(headers)
	# Grab the correct Requests request method
	req = getattr(requests, method)
	# It's expected that path *won't* start with a leading /
	# https://api.github.com/repos/{0}
	resource_uri = API_URI + path
	return req(resource_uri, data=data, params=params, headers=auth_headers)

so when we reach, the object is not working

webcompat.com/webcompat/api/endpoints.py

Lines 68 to 70 in e5dbd1c

	edit = api_request('patch', path, data=request.data)
	return (edit.content, edit.status_code,
	{'content-type': JSON_MIME_HTML})

The request has been correctly sent but the answers is not in the format we expect.

This is the shape of the content we receive once going through api_request, a tuple with 3 values.

While the edit.content, edit.status_code is trying to access properties of an object, this can be fixed with a quick hack testing the nature, the type of edit, but probably we need to make it more regular and that would require another bug.

[karlcow]

I created a new issue for fixing this issue in #3607