Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3522: Fix outreach comment for auth reports #3525

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented Jan 26, 2021

I've been getting issue id from public_url in WebHookIssue model, which gets extracted from the issue body:

public_url = extract_metadata(issue_body).get('public_url', '').strip()

However @public_url: is only added to the body of issues that require moderation. Therefore issues that are reported with github don't have it and the id is empty (ooops 🤦‍♀️).

To fix this I've used number property instead

@ksy36 ksy36 requested a review from karlcow January 26, 2021 21:10
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ksy36 for the quick fix and the test! 🧰

@karlcow karlcow merged commit 81945df into master Jan 26, 2021
@karlcow karlcow deleted the issue/3522/1 branch January 26, 2021 21:40
@ksy36
Copy link
Contributor Author

ksy36 commented Jan 27, 2021

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants