Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3467 - Comment the reason why an issue was accepted but closed #3472

Merged
merged 5 commits into from
Sep 2, 2020

Conversation

miketaylr
Copy link
Member

@miketaylr miketaylr commented Aug 31, 2020

r? @karlcow

No rush on the review.

@miketaylr

This comment has been minimized.

@miketaylr miketaylr force-pushed the issues/3467/1 branch 2 times, most recently from 45426a4 to 8d7954b Compare September 1, 2020 00:07
@miketaylr miketaylr marked this pull request as ready for review September 1, 2020 18:50
@miketaylr miketaylr requested a review from karlcow September 1, 2020 18:50
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good idea. The comments will give a better understanding too. and indeed for the ML will improve things.

@karlcow karlcow merged commit de18aa6 into master Sep 2, 2020
@karlcow karlcow deleted the issues/3467/1 branch September 2, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants