Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3450 - Remove is--visible class check, instead block on element being visible #3451

Merged
merged 1 commit into from
Aug 17, 2020
Merged

Fixes #3450 - Remove is--visible class check, instead block on element being visible #3451

merged 1 commit into from
Aug 17, 2020

Conversation

miketaylr
Copy link
Member

No description provided.

@miketaylr miketaylr changed the title Issue #3450 - Remove is--visible class check, instead block on element being visible Fixes #3450 - Remove is--visible class check, instead block on element being visible Aug 17, 2020
@miketaylr
Copy link
Member Author

First run was fine, but I re-ran it and got:

× chrome 84.0.4147.105 on Linux - Reporting with wizard - Learn more modal - closing with Esc (0.233s)
    AssertionError: expected 'popup-modal shadow' to include 'is--visible'
      at Command.<anonymous> @ tests/functional/reporting-issue-wizard-non-auth.js:649:20
      at runMicrotasks @ anonymous
      at Test.Learn more modal - closing with Esc [as test] @ tests/functional/reporting-issue-wizard-non-auth.js:648:12
      @ src/lib/Test.ts:268:51
      at runMicrotasks @ anonymous

@miketaylr
Copy link
Member Author

Ah, OK -- I forgot to apply the same "fix" to the rest of the test.

@miketaylr
Copy link
Member Author

OK, green on 2 re-spins and 2 runs locally. r=me

@miketaylr miketaylr merged commit bad7727 into master Aug 17, 2020
@miketaylr miketaylr deleted the issues/3450/1 branch August 17, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miketaylr