Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3392 - Refactor css after original form removal #3416

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Fixes #3392 - Refactor css after original form removal #3416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webcompat/static/css/src/footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.footer-item {
border-bottom: 1px solid var(--color-form);
border-bottom: 1px solid var(--color-footer);
padding: var(--unit-space) var(--unit-gap);
}

Expand Down
76 changes: 11 additions & 65 deletions webcompat/static/css/src/form.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,52 +11,13 @@
padding: 10px 0 35px;
}

.form-element-bottom {
display: flex;
flex-flow: column nowrap;
}

.form-element-bottom .form-button {
margin-top: auto;
}

.form-element {
margin: 0 0 20px;
max-width: 100%;
padding: 0;
position: relative;
}

.form-button-multiple {
align-items: center;
display: flex;
flex-wrap: wrap;
justify-content: space-between;
margin-left: -10px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These classes are no longer in use after deleting form.html

margin-right: -10px;
max-width: none;
}

.form-button-multiple .button-wrapper {
cursor: pointer;
display: flex;
flex: 1 1 auto;
margin: 20px 10px 0;
position: relative;
}

.form-button-multiple .button-wrapper .button {
flex: 1;
}

.form-button-multiple .button-wrapper .button:disabled {
pointer-events: none;
}

.form-button-multiple .button-wrapper:hover .button {
opacity: .85;
}

.form-field {
background: none;
color: inherit;
Expand Down Expand Up @@ -87,13 +48,6 @@
visibility: hidden;
}

.form-required::after {
color: var(--color-error);
content: "*";
padding-left: 7px;
padding-right: 7px;
}

.form-label-message .form-label {
display: inline-block;
}
Expand All @@ -105,15 +59,6 @@
font-weight: 700;
}

/* form text privacy */
.form-text-privacy {
background-color: var(--base-colorDark);
border-radius: 5px;
font-size: 14px;
padding: 6px;
text-align: center;
}

/* * Form input[type="text"], textarea (text-field) */

.text-field {
Expand All @@ -126,27 +71,28 @@
min-height: 27px;
padding: 8px 24px 8px 8px;
position: relative;
transition: box-shadow .3s;
width: 100%;
z-index: 2;
}

.text-field:focus {
border-bottom: 1px solid var(--color-first);
box-shadow: 0 0 0 2px var(--issue-type-bg);
outline: 1px solid transparent;
transition: border-bottom 1s linear;
}

/* * Form input[type="text"] validation */
@media (min-width: 665px) {
.text-field {
font-size: 100%;
}

.form-input-validation {
display: inline-block;
position: relative;
text-align: right;
top: -2em;
width: 100%;
z-index: 0;
.text-field:focus {
box-shadow: 0 0 0 3px var(--issue-type-bg);
}
}

/* * Form input[type="text"] validation */

.is-validated .check::after {
background-image: url("../../img/svg/icons/svg-checkmark.svg");
background-repeat: no-repeat;
Expand Down
4 changes: 0 additions & 4 deletions webcompat/static/css/src/issue-wizard-textarea.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@
width: 100%;
}

.progress-textarea .text-field {
font-weight: 200;
}

.progress-textarea .progress {
background: #b3f4d7;
border-radius: 2px;
Expand Down
30 changes: 6 additions & 24 deletions webcompat/static/css/src/issue-wizard.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,11 +435,7 @@
}

.issue-form .text-field {
border-color: var(--screenshot-shadow);
font-size: 14px;
font-weight: 200;
padding: 4px 32px 5px 8px;
transition: box-shadow .3s;
}

.with-validation-icons.is-validated .input-wrapper::after,
Expand Down Expand Up @@ -487,9 +483,6 @@
}

.low .text-field {
border-radius: 2px;
color: var(--color-second);
font-weight: 200;
margin-bottom: 17px;
padding: 5px 32px 7px 8px;
}
Expand All @@ -498,8 +491,8 @@
border-color: var(--wizard-step-error);
}

.low .text-field::placeholder {
color: var(--input-placeholder);
.issue-form .is-validated .text-field {
border-color: var(--issue-selected-outline);
}

.issue-btn {
Expand Down Expand Up @@ -653,14 +646,6 @@
width: 28px;
}

.issue-form .is-validated .text-field {
border-color: var(--issue-selected-outline);
}

.issue-form .text-field:focus {
box-shadow: 0 0 0 3px var(--issue-type-bg);
}

#browsers li {
width: 33%;
}
Expand Down Expand Up @@ -1031,18 +1016,15 @@
display: none;
}

.issue-form .text-field {
border-color: var(--color-form);
font-size: 90%;
.step-url .text-field {
font-weight: 600;
}

.issue-form .text-field {
padding: 11px 36px 11px 8px;
}

.low .text-field {
border-radius: 2px;
color: var(--color-second);
font-weight: 200;
margin-bottom: 17px;
padding: 5px 32px 7px 8px;
}

Expand Down
2 changes: 1 addition & 1 deletion webcompat/static/css/src/issue.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
}

.issue-new-comment .form-text {
padding: 0;
padding: 4px;
}

.issue-new-comment .text-field {
Expand Down
4 changes: 2 additions & 2 deletions webcompat/static/css/src/issues-list.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@
}

#x-search-bar .nav-button {
margin-left: -22px;
margin-top: -29px;
margin-left: -26px;
margin-top: -30px;
position: absolute;
z-index: 200;
}
15 changes: 2 additions & 13 deletions webcompat/static/css/src/label-editor.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,19 +142,8 @@
}

.label-editor-header .nav-button {
margin-top: -10px;
}

@media all and (min-width: 893.01px) {
.label-editor-header .nav-button {
margin-right: 5px;
}
}

@media all and (max-width: 893px) {
.label-editor-header .nav-button {
margin-right: -1px;
}
margin-left: 10px;
margin-top: -2px;
}

.wc-Issue-categoryEditor-button .label-editorLauncher {
Expand Down
5 changes: 3 additions & 2 deletions webcompat/static/css/src/nav.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,10 @@
margin: 0 auto;
max-width: var(--unit-modul-l);
min-width: var(--unit-modul-s);
padding: 0 10px;
position: absolute;
right: 0;
top: 1px;
top: 5px;
transform: rotateY(-90deg);
transition: all .2s ease 0s;
visibility: hidden;
Expand All @@ -108,7 +109,7 @@
float: right;
position: relative;
right: 10px;
top: -35px;
top: -32px;
z-index: 1300;
}

Expand Down
3 changes: 2 additions & 1 deletion webcompat/static/css/src/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
--color-second: rgba(64, 64, 64, 1); /* #404040 */
--color-third: rgba(240, 240, 240, 1); /* #f0f0f0 */
--color-fourth: rgba(192, 255, 238, 1); /* #c0ffee */
--color-form: rgba(0, 0, 0, .12); /* #000000 88% transparency */
--color-form: rgba(0, 0, 0, .4); /* #000000 40% transparency */
--color-footer: rgba(0, 0, 0, .12); /* #000000 12% transparency */
--color-default: rgba(196, 196, 196, 1); /* c4c4c4 */
--color-error: rgba(204, 23, 23, 1); /* #CC1717 */
--color-error-transparent: rgba(204, 23, 23, .8); /* #CC1717 20% transparency */
Expand Down
Loading