Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3316 - fixed misaligned check-marks #3363

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Issue #3316 - fixed misaligned check-marks #3363

merged 1 commit into from
Jun 29, 2020

Conversation

magsout
Copy link
Member

@magsout magsout commented Jun 26, 2020 •
edited
Loading

This PR fixes issue #3316

see sample https://share.getcloudapp.com/ApuAxkWO

@magsout magsout requested review from ksy36 and karlcow June 26, 2020 21:07
@magsout
Copy link
Member Author

magsout commented Jun 26, 2020

I added a wrapper around the input to have a constant height. We can add checkmarks in the center using absolute and a transform.

@karlcow
Copy link
Member

karlcow commented Jun 28, 2020

I let @ksy36 review the JS part.
Thanks a lot @magsout

ksy36
ksy36 approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@ksy36 ksy36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this @magsout

@ksy36 ksy36 merged commit abea7ce into master Jun 29, 2020
@ksy36 ksy36 deleted the issues/3316 branch June 29, 2020 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlcow karlcow karlcow approved these changes

@ksy36 ksy36 ksy36 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magsout @karlcow @ksy36 @miketaylr