-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #3310 - improves tests documentation #3312
Conversation
@miketaylr I kind of did it in the opposite way ;) I changed the documentation, but if you want I can add to this pull request at least one converted file. So we could link the diff to the documentation. WDYT? |
Let's make it a draft to not do accidental merge. |
I am shocked 😱
These are great improvements. r+++++ I think with just the skeleton example you linked, it's enough to learn from. But converting one additional file wouldn't hurt, if you're up to it. Basically, I'll leave it up to you. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ in case you want to just merge here.
* Adds documentation for pytests * Fixes outdated links to documentation * Fixes the table of content * Adds a template for Python tests using pytest * Adds information about data fixtures
@miketaylr what about two files converted. :) That was an interesting learning process and an opportunity to tweak a couple of things for the tests. Using some nice features of pytests here and there. @ksy36 might be interested by the modifications I have done to the tests for console log file. I think it will be fun to convert the other tests. It's not always easy because we have to change the mindset a bit. But in the end this is fun. |
ok all green. |
awesome, thank you! |
This PR fixes issue #3310