Fixes #3049 - Clear the image preview when hitting an error #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miketaylr
changed the title
miketaylr
force-pushed
the
issues/3049/1
branch
from
9a33401 to
f3b4d1c
Compare
added 2 commits
October 29, 2019 11:36
We're testing that we can handle the scenario of an invalid image, after receiving an already valid one.
|
r? @ksy36 (after PTO is fine, this is sort of an edge case bug) |
miketaylr
commented
Oct 30, 2019
| // show the upload label when we're responding to a click event | ||
| // (instead of being called from an error handler, which will | ||
| // display its own error label) | ||
| event.preventDefault(); |
There was a problem hiding this comment.
(honestly, i don't know why we're preventDefaulting here and not in the other bugform.js, -- I suspect it's not actually needed)
ksy36
approved these changes
Nov 4, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to write some tests first.
edit: Done.