Fixes #2938 - Implement mobile redesign on bug form #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2019
miketaylr
approved these changes
Oct 16, 2019
|
|
||
| s.addEventListener("touchend", e => { | ||
| touchendX = e.changedTouches[0].screenX; | ||
| handleGesure(); |
There was a problem hiding this comment.
I'm not sure if we should make these touch handlers passive or not, but maybe something to consider.
|
@karlcow can we deploy master to staging for some testing? |
|
on my todo for today. Brace for impact. |
fab deploy -t staging master is deployed to staging. There is no visible difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2938 - Implement mobile redesign on the bug form. The mobile view is all about style updates that make the page responsive. Each commit has its own issue which brings more light into what the changes are about.