Issue #2958 - Fix ab_active to populate cookies on first request
#2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equest * Cleanup tests: Instead of mocking `g.user` run `preprocess_request`
miketaylr
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2958
Proposed PR background
There was an issue on the way that we check if an experiment is active.
ab_activehelper instead of checking theg.current_experimentsdict that we populate before each request, was checking the actual cookies. That means that on the first requestab_activewas failing to give the proper result because cookies where not populated.Changes introduced in the commit:
ab_activebehaviourI tested in 2 temp firefox containers and it looks like experiment cookies are loaded on first request.