Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2509: Fixed race condition when image didn't get transferred from report site issue extension #2885

Merged
merged 3 commits into from
May 30, 2019

Conversation

ksy36
Copy link
Contributor

@ksy36 ksy36 commented May 30, 2019

Copy link
Member

@wisniewskit wisniewskit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Worth having a second set of eyes on it though, in case our approach is disagreeable.

@wisniewskit
Copy link
Member

Mike, could you take a look at this as well? This change looks hefty, but if you look at the individual commits, it's not really that evil. The first commit is just us unindenting functions and putting them on the prototype of Bugform (so that they are created when the page loads, not after jQuery.ready).

The second commit is the actual interesting change, where we just change how the constructor of BugForm works so that it calls jQuery.ready at appropriate times, so the message-listener is added right away, but it only actually handles the message after jQuery.ready.

@wisniewskit wisniewskit requested a review from miketaylr May 30, 2019 19:48
@miketaylr
Copy link
Member

Yep, this looks good. Reviewing each commit is less scary. :)

@miketaylr miketaylr merged commit 7b1cf82 into master May 30, 2019
@miketaylr miketaylr deleted the issue/2509/1 branch May 30, 2019 21:55
@karlcow
Copy link
Member

karlcow commented May 30, 2019

Thanks a lot @ksy36 and @wisniewskit !!!

@karlcow
Copy link
Member

karlcow commented May 30, 2019

I'll deploy this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants