Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1838 - Separates the python dependencies into prod and dev #2834

Merged
merged 4 commits into from
Apr 4, 2019

Conversation

karlcow
Copy link
Member

@karlcow karlcow commented Apr 4, 2019

This PR fixes issue #1838

Proposed PR background

This is the first step of properly separating the production and the development environment. Once this is done, we can think of ways to modify the fabfile so it deploys only the prod environment.

r? @miketaylr

@karlcow karlcow requested a review from miketaylr April 4, 2019 05:47
@karlcow
Copy link
Member Author

karlcow commented Apr 4, 2019

This also requires to have #2829 merged BEFORE this one.

@karlcow karlcow force-pushed the 1838/1 branch 2 times, most recently from 73cc52f to 44e64db Compare April 4, 2019 05:58
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, but please fix the comment in run.py before merging.

@karlcow karlcow merged commit 4bcbb9a into webcompat:master Apr 4, 2019
@karlcow karlcow deleted the 1838/1 branch May 9, 2019 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants