-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2778 - Implements HTTP/2 Push through Flask #2792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marimeireles This is good work.
I wonder if there is a conflict in between HTML and HTTP. Maybe as a test we could
- remove from the HTML template to see if it's working
- Pass the values to the HTML template to see if it's working better.
@karlcow can you (re-)deploy this branch to staging? I tried, but apparently it doesn't like me. The fabfile is asking for a pw, that I guess I don't have (or possibly it changed)? |
Probably the issue we talk about last week. I will deploy this branch. It has not been deployed yet. |
@miketaylr @marimeireles Firehose lib branch deployed on staging as of now. |
Thanks for the help Karl and Mike. |
See @marimeireles' comment |
578bd2b
to
9f07b7b
Compare
r? @karlcow |
e1183f1
to
9b8847a
Compare
Does it look good for you @karlcow ? |
The rest looks good to me. thanks a lot. Once you put back the order of nosetest, I'll approve and merge. |
c2d64cb
to
ac739a6
Compare
@karlcow are we good to merge here? thanks. |
I will double check the config on prod and staging today. And we could probably merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for everything @marimeireles
These are the relevant changes to test the firehose lib reponsible for making push requests on Flask.
Can you please add them to Staging? So we can test if there is something wrong with my local nginx configuration.
Here is some more context to why we're doing this: #2778 (comment)
r? @miketaylr
Thanks!