Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2782 - Edit dev-env-setup.md around GH client ID/secret + typos #2786

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

laghee
Copy link
Contributor

@laghee laghee commented Jan 29, 2019

This PR fixes issue #2782

Proposed PR background

  • Deletes sentence that claims webcompat org members can retrieve the GH client ID & secret from settings (which only org owners can access)
  • Fixes some typos and formatting inconsistencies (some of these might be subjective)

@laghee laghee requested a review from karlcow January 29, 2019 19:51
Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laghee

different markdown style ;)

just one request to improve the list formatting.

@laghee
Copy link
Contributor Author

laghee commented Jan 30, 2019

different markdown style ;)

Oh, weird, you're right -- I didn't even notice that! Apparently my vscode markdown plugin is very aggressive about changes without explicit approval... how annoying. I think I can roll those back by mucking with settings if necessary.


#### Installing Windows Substem for Linux
#### Installing Windows Subsystem for Linux
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, nice find.

@miketaylr
Copy link
Member

I think I can roll those back by mucking with settings if necessary.

I'm not sure it really matters, as long as the end result is the same.

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go with it.

@karlcow karlcow merged commit e80cc78 into webcompat:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants