Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2764 - Updates intern dep. to a version that's not broken #2773

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

marimeireles
Copy link
Member

No description provided.

@miketaylr
Copy link
Member

TOTAL: tested 2 platforms, 169 passed, 1 failed

Getting closer! Let me restart the tests and see if it changes.

@miketaylr
Copy link
Member

For the record, the fail was:

127.0.0.1 - - [23/Jan/2019 16:52:44] "GET /api/issues/category/needstriage?per_page=5 HTTP/1.1" 200 -
× firefox on linux 4.4.0-141-generic - Index - browse issues (needstriage) (0.177s)
    AssertionError: Link should have a number: expected 'http://localhost:5000/issues/408' to match /^\/issues\/\d+$/
      at Command.<anonymous>  <tests/functional/index-non-auth.js:76:18>
      at Test.browse issues (needstriage) [as test]  <tests/functional/index-non-auth.js:75:10>
      at <src/lib/Test.ts:263:51>

@miketaylr
Copy link
Member

That code hasn't been touched in over a year... did we change what we're sticking in the href?

@miketaylr
Copy link
Member

screen shot 2019-01-23 at 3 38 49 pm

Doesn't look like it. Possibly a new version of geckodriver returns the fully resolved href instead of what's literally in the attribute. Either way, we can just fix this by removing the ^ and just use /\/issues\/\d+$/ there -- that's not what we're testing.

@miketaylr miketaylr self-requested a review January 23, 2019 21:42
Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marimeireles can you try the test tweak I mentioned?

Copy link
Member

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants