Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lint-staged to the latest version 🚀 #2685

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Oct 29, 2018

The devDependency lint-staged was updated from 7.3.0 to 8.0.0.

This version is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Release Notes for v8.0.0

8.0.0 (2018-10-29)

Features

  • Add support for partially staged files (#75) (f82443c), closes #62

BREAKING CHANGES

  • Node >= 8.6 is required
Commits

The new version differs by 5 commits.

  • f82443c feat: Add support for partially staged files (#75)
  • e6a6ec6 chore: upgrade to jest 23 (#507)
  • f05ada6 docs: Add an example for type checking with flow (#502)
  • bcd0af4 docs: Add SurviveJS link
  • d782fa1 docs: Update documentation for husky 1.0 (#496)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@miketaylr
Copy link
Member

miketaylr commented Oct 29, 2018

version 8 changelog:

 Features

    Add support for partially staged files (#75) (f82443c), closes #62

BREAKING CHANGES

    Node >= 8.6 is required

Probably safe to merge, what do you think @magsout? I guess we should update the docs to mention the minimum node version tho.

greenkeeper bot added a commit that referenced this pull request Oct 29, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 29, 2018

  • The devDependency lint-staged was updated from 7.3.0 to 8.0.1.

Update to this version instead 🚀

Release Notes for v8.0.1

8.0.1 (2018-10-29)

Bug Fixes

  • git: Use resolveGitDir to resolve to .git for git commands (#518) (da42f8a), closes #514
Commits

The new version differs by 2 commits.

  • da42f8a fix(git): Use resolveGitDir to resolve to .git for git commands (#518)
  • 592486f docs: Update readme to include info about partially staged files support

See the full diff

greenkeeper bot added a commit that referenced this pull request Oct 29, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 29, 2018

  • The devDependency lint-staged was updated from 7.3.0 to 8.0.2.

Update to this version instead 🚀

Release Notes for v8.0.2

8.0.2 (2018-10-29)

Bug Fixes

  • git: Use resolveGitDir in hasPartiallyStagedFiles (#520) (af99172), closes #514
Commits

The new version differs by 1 commits.

  • af99172 fix(git): Use resolveGitDir in hasPartiallyStagedFiles (#520)

See the full diff

@magsout
Copy link
Member

magsout commented Oct 30, 2018

@miketaylr yes good point. We also need to update the package.json https://github.com/webcompat/webcompat.com/blob/master/package.json#L14

But I opened an issue about if lint-staged is relevant or not? #2676

greenkeeper bot added a commit that referenced this pull request Oct 30, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 30, 2018

  • The devDependency lint-staged was updated from 7.3.0 to 8.0.3.

Update to this version instead 🚀

Release Notes for v8.0.3

8.0.3 (2018-10-30)

Bug Fixes

Commits

The new version differs by 1 commits.

  • 225a904 fix: Allow to use lint-staged on CI (#523)

See the full diff

@miketaylr
Copy link
Member

Filed #2689

greenkeeper bot added a commit that referenced this pull request Oct 31, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 31, 2018

  • The devDependency lint-staged was updated from 7.3.0 to 8.0.4.

Update to this version instead 🚀

Release Notes for v8.0.4

8.0.4 (2018-10-31)

Bug Fixes

  • package: update staged-git-files to version 1.1.2 (ce434d3)
Commits

The new version differs by 6 commits.

  • 5e165a3 Merge pull request #513 from okonet/greenkeeper/staged-git-files-1.1.2
  • 07fd087 Merge branch 'master' into greenkeeper/staged-git-files-1.1.2
  • 00047de docs: fix typo (#527)
  • bedba5a refactor: Use object spread (#524)
  • c4e8a2d chore(package): update lockfile yarn.lock
  • ce434d3 fix(package): update staged-git-files to version 1.1.2

See the full diff

@miketaylr miketaylr merged commit f9589ab into master Oct 31, 2018
@miketaylr miketaylr deleted the greenkeeper/lint-staged-8.0.0 branch October 31, 2018 15:40
@miketaylr
Copy link
Member

hmmmmm.

Warning: Setting pre-commit script in package.json > scripts will be deprecated
Please move it to husky.hooks in package.json, a .huskyrc file, or a husky.config.js file
Or run ./node_modules/.bin/husky-upgrade for automatic update

See https://github.com/typicode/husky for usage

husky > pre-commit (node v11.0.0)
`lint-staged` no longer supports running scripts defined in package.json.

The same behavior can be achieved by changing the command to any of the following:
  - `npm run lint:js -- `
  - `eslint ./Gruntfile.js ./tests ./grunt-tasks ./webcompat/static/js/lib `
  ↓ Stashing changes... [skipped]
    → No partially staged files found...
  ❯ Running linters...
    ✖ Running tasks for *.js
      → Could not resolve binary for `lint:js`
    ↓ Running tasks for *.css [skipped]
      → No staged files match *.css
Could not resolve binary for `lint:js`
husky > pre-commit hook failed (add --no-verify to bypass)

@miketaylr
Copy link
Member

(somehow my local setup is weird... this might not be a real issue)

@miketaylr
Copy link
Member

ok, lint-staged no longer supports running scripts defined in package.json.`

that's annoying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants