Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2651. Update docs around secrets and environment #2652

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

miketaylr
Copy link
Member

Sorry to everyone who tried to set up the project in the past week...

r? @karlcow

@karlcow
Copy link
Member

karlcow commented Oct 14, 2018

@miketaylr interesting the commit doesn't show up in #2621

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we need a little script in run.py to detect that the config has been changed.

@karlcow karlcow merged commit e35c82f into master Oct 14, 2018
@miketaylr miketaylr changed the title Fixes #2621. Update docs around secrets and environment Fixes #2651. Update docs around secrets and environment Oct 15, 2018
@miketaylr
Copy link
Member Author

Oops yeah, wrong issue number. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants