Issue #2320 - Adds wc-Comment-content-nsfw to new CSS

[marimeireles]

This PR fixes issue #2320

It's necessary to add a nsfw label to the github repository in order for these changes to work.

r? @magsout

---

• I have read the Pull Request + Code Style Guidelines thoroughly.

[magsout]

@marimeireles thanks. The logic of nsfw is back.

In the issue #2320 there are two purposes.

1. Logic back
2. Consistency in naming

You did the first step, but no the second step.

So you have to update the className in the css file and the js file to be consistency with the classNames

[miketaylr]

consistency with the classNames

Is the style we should be using documented somewhere @magsout? I'm not sure I even know. :))

[magsout]

Is the style we should be using documented somewhere @magsout? I'm not sure I even know. :))

Good question @miketaylr and I would say, no.

It's just about feeling of what kind of component you're coding and/or where you're adding properties.

It's very subjective so I think it would be nice to document that.

For this issue, I would say something like : .issue-details-nsfw ?

[marimeireles]

@miketaylr Thanks for the question.
@magsout Sorry for that. When you said I should adapt it to css atomic I read a little bit about it on the internet and I thought I was fine.

I followed your recommendation in this new pr.

[magsout]

@marimeireles

@magsout Sorry for that. When you said I should adapt it to css atomic I read a little bit about it on the internet and I thought I was fine.

My bad, I should have been more specific.

Perfect for the css part 👍 good job.

Just one thing and after that i think we can merge, we need to update className in JS files :

webcompat.com/webcompat/static/js/lib/issues.js

Line 176 in cc26a91

.addClass("wc-Comment-content-nsfw");

webcompat.com/webcompat/static/js/lib/issues.js

Line 334 in 173d092

"click .wc-Comment-content-nsfw": "toggleNSFW"

webcompat.com/webcompat/static/js/lib/issues.js

Line 515 in 173d092

.addClass("wc-Comment-content-nsfw");

then same thing for all className wc-Comment-content-nsfw" in the functional test

webcompat.com/tests/functional/issues-non-auth.js

Line 85 in cfebc90

assert.include(className, "wc-Comment-content-nsfw");

webcompat.com/tests/functional/issues-non-auth.js

Line 97 in cfebc90

assert.include(className, "wc-Comment-content-nsfw");

webcompat.com/tests/functional/issues-non-auth.js

Line 98 in cfebc90

assert.notInclude(className, "wc-Comment-content-nsfw--display");

webcompat.com/tests/functional/issues-non-auth.js

Line 105 in cfebc90

assert.include(className, "wc-Comment-content-nsfw");

webcompat.com/tests/functional/issues-non-auth.js

Line 106 in cfebc90

assert.include(className, "wc-Comment-content-nsfw--display");

webcompat.com/tests/functional/issues-non-auth.js

Line 113 in cfebc90

assert.include(className, "wc-Comment-content-nsfw");

webcompat.com/tests/functional/issues-non-auth.js

Line 114 in cfebc90

assert.notInclude(className, "wc-Comment-content-nsfw--display");

[marimeireles]

Sorry for taking so long and forgetting to change on the other files! :(

[magsout]

@marimeireles awesome. Good job, and thanks a lot.